Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a basic Autocompletion to the script window #8658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Nov 23, 2023

@lloyddewit as discussed yesterday, I have implemented here a basic autompletion following the C# example from Jacob. Some keywords are probably missing but have a look.

@lloyddewit
Copy link
Contributor

@N-thony Thank you, this looks like a good approach.
Is it ready for @rdstern to test?
When @rdstern has tested/approved, then I can do a full peer review.

@N-thony
Copy link
Collaborator Author

N-thony commented Nov 23, 2023

@N-thony Thank you, this looks like a good approach. Is it ready for @rdstern to test? When @rdstern has tested/approved, then I can do a full peer review.

Yes, @rdstern can also test.

@rdstern
Copy link
Collaborator

rdstern commented Nov 23, 2023

@N-thony so I had a look, though I am not sure what to expect.

I couldn't get it to do anything when I put a script in and hovered, etc.

So I started typing new lines and it gave me some words I could use. I chose 1 and it included it. I chose cut

What's next?

Can it include the names easily of many R commands, from different packages?
Can it include the names of our special R-Instat functions?
Can it suggest allowed parameters for the functions names it chooses? Or is it just their names?

@rdstern
Copy link
Collaborator

rdstern commented Dec 16, 2023

@N-thony I am still not sure whether more time on autocomplete can be a priority now? I am looking for "quick-wins" and this feature is more for R code developers than users.

The same issue, number #8646 is titled with the hopefully small task, that I would really like and that is to make the cursor visible in a script. I wonder if this could be included here?

@N-thony
Copy link
Collaborator Author

N-thony commented Jan 7, 2024

@rdstern I have added here the code to maintain the cursor visible when you run the command with Run or Run All button

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony I am very happy to see the cursor and would very much like to merge this. But the autocompletion is now also automatically there and it never gives me any useful suggestions at this stage. So, could that be disabled for now?

@N-thony
Copy link
Collaborator Author

N-thony commented Jan 8, 2024

@N-thony I am very happy to see the cursor and would very much like to merge this. But the autocompletion is now also automatically there and it never gives me any useful suggestions at this stage. So, could that be disabled for now?

@rdstern I will move the code to another PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants