Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the Use table dialog #9170

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

derekagorhom
Copy link
Contributor

@derekagorhom derekagorhom commented Oct 2, 2024

Fixes #9142
I have done parts a, b, and c of this issue
@rdstern can you review this
Thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekagorhom that's fine as far as it goes. Here is the dialog now:

image

Usually I would suggest we could merge this and then you continue. But here there is no point, because the dialog doesn'r do anything until you start yo implement at least one of the saving methods - in addition to html. That's the whole point now, of this dialog. Later there will be more. So please can you proceed, perhaps starting with the Word option, though you may find that as soon as you do one you can do them all. Ask @Patowhiz pr @N-thony if you need help. It looks reasonably straightforward in the gt documentation?

@rdstern
Copy link
Collaborator

rdstern commented Oct 9, 2024

@derekagorhom I assume you are still working on this, as still nothing is enabled. I'm keen also for something in addition from html, which is the default anyway.

@derekagorhom
Copy link
Contributor Author

@rdstern I have enabled the export options now.
i used gtsave function for the export
gtsave(data, filename, path = NULL, ...)
i allowed the path in which the tables should be exported into to be the my documents folder for the user.
the only problem is from the word option, while trying it i encountered this error.
image
Apart from the word option, the other options seem to work fine.
Thanks

@rdstern
Copy link
Collaborator

rdstern commented Oct 10, 2024

@derekagorhom that seems like an excellent start. @Patowhiz maybe you could check, so far, and also see whether there is an obvious fix to theWord export?
I wonder as follows:
a) Could the export work for multiple tables at the same time? So could we change the receiver to be a multiple receiver, and export them all into one word, rtf or LaTex file?
b) Later I hope there will be options to improve the gt table object as well. So the export will become just one option from this dialog. When used, should we replace the Store Table option with an Export File dialog. This should then be like the dialogs in the File > Export dialog, so we can choose where to save the exported file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort out the initial Use Table dialog
2 participants