chore: code tidying

IDEMSInternational · Sep 25, 2024 · 2959c96 · 2959c96
1 parent 1db2371
commit 2959c96
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/scripts/src/commands/app-data/convert/processors/base.ts b/packages/scripts/src/commands/app-data/convert/processors/base.ts
@@ -26,7 +26,10 @@ class BaseProcessor<T = any, V = any> {
   constructor(public context: { namespace: string; paths: IConverterPaths; cacheVersion: number }) {
     const { namespace } = context;
     this.logger = createChildFileLogger({ source: namespace });
-    this.setupCache();
+    // HACK - support tests by avoiding setup if folderPath not provided
+    if (context.paths) {
+      this.setupCache();
+    }
   }
   /**
    * Create a namespaced cache folder and populate a list of all files currently cached,

diff --git a/packages/scripts/src/commands/app-data/convert/processors/flowParser/flowParser.ts b/packages/scripts/src/commands/app-data/convert/processors/flowParser/flowParser.ts
@@ -64,10 +64,8 @@ export class FlowParserProcessor extends BaseProcessor<FlowTypes.FlowTypeWithDat
 
   public updateProcessedFlowHashmap(flow: FlowTypes.FlowTypeWithData) {
     const { flow_name, flow_type, _xlsxPath } = flow;
-    if (!this.processedFlowHashmap[flow_type]) {
-      this.processedFlowHashmap[flow_type] = {};
-      this.processedFlowHashmapWithMeta[flow_type] = {};
-    }
+    this.processedFlowHashmap[flow_type] ??= {};
+    this.processedFlowHashmapWithMeta[flow_type] ??= {};
     // NOTE - duplicate flows are identified up during main converter
     this.processedFlowHashmap[flow_type][flow_name] = flow.rows;
     this.processedFlowHashmapWithMeta[flow_type][flow_name] = flow;

diff --git a/...s/scripts/src/commands/app-data/convert/processors/flowParser/parsers/data_pipe.parser.ts b/...s/scripts/src/commands/app-data/convert/processors/flowParser/parsers/data_pipe.parser.ts
@@ -29,8 +29,6 @@ export class DataPipeParser extends DefaultParser<FlowTypes.DataPipeFlow> {
   }
 
   private populateGeneratedFlows(outputs: { [output_name: string]: any[] }) {
-    this.flowProcessor.processedFlowHashmap.data_list ??= {};
-
     for (const [flow_name, rows] of Object.entries(outputs)) {
       const flow: FlowTypes.FlowTypeWithData = {
         flow_name,