Skip to content

Commit

Permalink
fix: Consistency of ripple effects have been made consistent across t…
Browse files Browse the repository at this point in the history
…he buttons.
  • Loading branch information
kwAsant committed Aug 28, 2024
1 parent 356e638 commit 98b75a4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
Empty file modified packages/scripts/bin/app-scripts
100644 → 100755
Empty file.
Empty file modified packages/scripts/bin/app-workflow
100644 → 100755
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
[attr.data-rowname]="_row.name"
></plh-template-component>
</span>
<ion-ripple-effect></ion-ripple-effect>
</ion-button>

<!-- "card-portrait" variant. This variant is not achievable using an ion-button -->
Expand All @@ -49,7 +48,6 @@
[parent]="parent"
[attr.data-rowname]="_row.name"
></plh-template-component>
<ion-ripple-effect></ion-ripple-effect>
</span>
</div>
</ng-container>
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ ion-button[data-variant~="card"] {
}
}

// set the speed of the ripple effect to ensure that it is consistent across all buttons
.ion-ripple-effect {
--ion-ripple-duration: 500ms;
}

.button-container[data-variant~="card-portrait"] {
background-color: white;
color: var(--ion-color-primary);
Expand Down

0 comments on commit 98b75a4

Please sign in to comment.