Set custom domain for documentation site #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'documentation-deploy' flow overwrites everything in the 'gh-pages' branch every time there is a push to the master branch - that is why files like CNAME go missing. There is a setting on the action that generates the site that should set a custom domain name, which has been set appropriately. Upgraded the checkout action. Removed commented code and todo.
ChrisMarsh82
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent the open-app-builder.com site from going down every time there is a commit to the master branch.
The 'documentation-deploy' flow overwrites everything in the 'gh-pages' branch every time there is a push to the master branch - that is why files like CNAME go missing, which causes downtime. There is a setting on the action that generates the site that should set a custom domain name, and this has been set appropriately.
Upgraded the checkout action. Removed commented code and todo.