Update reusable-content-sync.yml #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defined secrets explicitly so can be passed from other organisations. Removed Deployment Private Key as not used
jfmcquade
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Makes sense. I suppose there isn't a way to test that running from a different org's repo correctly passes in the secrets until after we've merged?
It could be worth keeping the DEPLOYMENT_PRIVATE_KEY as an optional secret (and using it to decrypt the config if it is supplied), as possibly in the future there could be a value from the encrypted deployment folder that is required for syncing content – e.g. a folder ID or URL that is considered sensitive. I can't really see an immediate use-case for that though, so happy to merge as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined secrets explicitly so can be passed from other organisations.
Removed Deployment Private Key as not used