Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - Add PhysX Ropes as "connector wires" for Infantry-Phone/GSA/External #1290

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Core - Add PhysX Ropes as "connector wires" for Infantry-Phone/GSA/External #1290

wants to merge 37 commits into from
+210 −14

Commits on Mar 17, 2024

  1. Rope handler

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c12d85d View commit details
    Browse the repository at this point in the history

  2. Infantry phone uses rope

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c88a534 View commit details
    Browse the repository at this point in the history

  3. Overhauled handler 

    Working better on Infantry Phone, not working on GSA, implemented but not tested for Shared Radios.
    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5be06e5 View commit details
    Browse the repository at this point in the history

  4. Fixed oversight from a variable renaming

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    bfd7313 View commit details
    Browse the repository at this point in the history

  5. Changed attach method for GSA rope 

    Using a smaller "PaperCar" object instead of bulky "RoadCone".
Disabling collisions and moving the "PaperCar" helper on the GSA instead of attachTo-ing resolves the issue of the rope not attaching to the player's helper.
    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    efd0a70 View commit details
    Browse the repository at this point in the history

  6. Break rope on GSA max distance disconnect

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    fb156ba View commit details
    Browse the repository at this point in the history

  7. Use ACE Refueling Hose as connector rope

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    210f01b View commit details
    Browse the repository at this point in the history

  8. Possible fix for rope blocking disconnect interaction

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    d9860cb View commit details
    Browse the repository at this point in the history

  9. Add CBA Setting under sys_gestures

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    9c1a375 View commit details
    Browse the repository at this point in the history

  10. Gave rope some slack at usual connection distances

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    9f2c84a View commit details
    Browse the repository at this point in the history

  11. Made hose->wire model thinner

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    cfe2085 View commit details
    Browse the repository at this point in the history

  12. Find rope start position more efficiently 

    By fully using the passed parameters instead of fetching it from config again
    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    47839cb View commit details
    Browse the repository at this point in the history

  13. Prevent taking infantry phone that is being used

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    a3ad3a9 View commit details
    Browse the repository at this point in the history

  14. Concentrate intercom wire handling in "updateInfantryPhoneStatus"

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    2db6cc0 View commit details
    Browse the repository at this point in the history

  15. Use "PaperCar" as a helper object on both ends

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    22c0c78 View commit details
    Browse the repository at this point in the history

  16. Hide all helper objects globally

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    12f106a View commit details
    Browse the repository at this point in the history

  17. Cleaned up systemChat and Comment

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    73b0061 View commit details
    Browse the repository at this point in the history

  18. Custom Rope Helper Object 

    Reuses the PaperCar model
    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    cdfd44d View commit details
    Browse the repository at this point in the history

  19. More local var use, reducing macro invocations

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    ef36edc View commit details
    Browse the repository at this point in the history

  20. Properly run hideObjectGlobal on Server 

    Rough quick fix via remoteExec.
    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    08290a4 View commit details
    Browse the repository at this point in the history

  21. Use passed parameter instead of defaulting to player

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    9be34ab View commit details
    Browse the repository at this point in the history

  22. Delete rope via CBA Event if someone else picks up GSA

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c86bd4f View commit details
    Browse the repository at this point in the history

  23. Hide Rope Helpers via CBA Server Events

    @mrschick
    mrschick committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    a1938f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Use CBA Events for all GSA Rope Handling 

    This seems like the best solution, due to the complexity of the GSA connection handling and the different ways connection can be influenced by remote players.
    @mrschick
    mrschick committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0a23f66 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Fix desync when adding/removing mast on GSA 

    Doing so would create a desync / double connection if someone else was connected to the GSA, that's because the code wouldn't run the disconnect/reconnect events on the previously connected player but only on the one triggering the interaction.
    @mrschick
    mrschick committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    32bb482 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Use CBA Events for Infantryphone Rope Handling

    @mrschick
    mrschick committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    87f6d84 View commit details
    Browse the repository at this point in the history

  2. Shorten external radio rope to 1.2m

    @mrschick
    mrschick committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bd0877c View commit details
    Browse the repository at this point in the history

  3. Fix implementation on external radios

    @mrschick
    mrschick committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b2b266a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Handle External Radio Rope on the user instead of the owner 

    This is to prevent issues in the case of the radio owner being connected to a GSA while sharing his radio.
    @mrschick
    mrschick committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9d8272d View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Reword Translation 

    Co-authored-by: Mike-MF <[email protected]>
    @mrschick @Mike-MF
    mrschick and Mike-MF authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4c2d984 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: jonpas <[email protected]>
    @mrschick @jonpas
    mrschick and jonpas authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    517de6e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Drop unused argument

    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    41daddd View commit details
    Browse the repository at this point in the history

  2. More appropriate init value

    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9c89720 View commit details
    Browse the repository at this point in the history

  3. Remove External Radio Rope handling 

    Unfeasible due to engine limitations, which prevent global attachment of a rope if its start is on an object that is attachTo-ed a player unit.
    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6926891 View commit details
    Browse the repository at this point in the history

  4. Use defined value instead of "constant" var

    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5e10245 View commit details
    Browse the repository at this point in the history

  5. Fix Intercom Passing

    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    87b8ee8 View commit details
    Browse the repository at this point in the history

  6. Prevent multiple rope creation, destroy previous

    @mrschick
    mrschick committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f2b3e0b View commit details
    Browse the repository at this point in the history