Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - Show error if plugin not found #1292

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Core - Show error if plugin not found #1292

merged 1 commit into from
Oct 12, 2023

Conversation

PabstMirror
Copy link
Collaborator

Close #1291

@PabstMirror PabstMirror added this to the Ongoing milestone Sep 27, 2023
@jonpas
Copy link
Member

jonpas commented Sep 27, 2023

That won't also fix the script error, right?

@jonpas jonpas changed the title sys_core - show error if plugin not found Core - Show error if plugin not found Sep 27, 2023
@PabstMirror
Copy link
Collaborator Author

It makes it clear why there's an script error
I don't really want to add overhead for something this rare

@jonpas
Copy link
Member

jonpas commented Sep 27, 2023

Error is similar to what I got last time on radios failure, maybe it would be worth adding some simple check. Could just do for a debug build?

@jonpas jonpas modified the milestones: Ongoing, 2.12.0 Oct 12, 2023
@jonpas jonpas merged commit 8b3cb76 into master Oct 12, 2023
3 checks passed
@jonpas jonpas deleted the pluginerror branch October 12, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Handle Missing extension errors gracefully
2 participants
@PabstMirror @jonpas