Sourcery refactored main branch #1
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if "format" in _json: | ||
| if "duration" in _json["format"]: | ||
| return float(_json["format"]["duration"]) | ||
| if "format" in _json and "duration" in _json["format"]: | ||
| return float(_json["format"]["duration"]) |
There was a problem hiding this comment.
Function duration refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
| qualityList = [] | ||
| r = ydl.extract_info(yturl, download=False) | ||
| for format in r["formats"]: | ||
| # Filter dash video(without audio) | ||
| if not "dash" in str(format["format"]).lower(): | ||
| qualityList.append( | ||
| { | ||
| "format": format["format"], | ||
| "filesize": format["filesize"], | ||
| "format_id": format["format_id"], | ||
| "yturl": yturl, | ||
| } | ||
| ) | ||
| qualityList = [ | ||
| { | ||
| "format": format["format"], | ||
| "filesize": format["filesize"], | ||
| "format_id": format["format_id"], | ||
| "yturl": yturl, | ||
| } | ||
| for format in r["formats"] | ||
| if "dash" not in str(format["format"]).lower() | ||
| ] |
There was a problem hiding this comment.
Function extractYt refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Convert for loop into list comprehension (
list-comprehension) - Simplify logical expression using De Morgan identities (
de-morgan)
This removes the following comments ( why? ):
# Filter dash video(without audio)
| filename = t_response.split("Merging formats into")[-1].split('"')[1] | ||
| return filename | ||
| return t_response.split("Merging formats into")[-1].split('"')[1] |
There was a problem hiding this comment.
Function downloadvideocli refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| helptxt = ( | ||
| f"Currently Only supports Youtube Single (No playlist) Just Send Youtube Url" | ||
| ) | ||
| helptxt = 'Currently Only supports Youtube Single (No playlist) Just Send Youtube Url' | ||
|
|
There was a problem hiding this comment.
Function start refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
| if num is None: | ||
| num = 0 | ||
| else: | ||
| num = int(num) | ||
|
|
||
| num = 0 if num is None else int(num) |
There was a problem hiding this comment.
Function humanbytes refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 1.34%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!