Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roiimport plugin and readers for idr0012 and idr0016 #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominikl
Copy link
Member

Replaces the separate project specific roi import plugins #290 and #287 with a generic roiimport plugin which uses different ROIReaders to read the project specific HDF5 files.
For other projects only the respective ROIReader has to implemented.

Test on idr-testing with idr0012:
./omero roiimport import idr012.h5 1202 --format=idr0012 --dry-run

With idr0016:
./omero roiimport import idr016.h5 1952 --format=idr0016 --dry-run

@dominikl
Copy link
Member Author

There's still the issue, that for idr0012, there are ROIs for 4 spots per well in the hdf5 file, but there only two images (fields) per well in OMERO. No idea, how to map that...

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build IDR-push#4. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • idr0002-heriche-condensation
    • idr0007-srikumar-sumo
    • idr0008-rohn-actinome
    • idr0017-breinig-drugscreen
    • idr0018-neff-histopathology
    • idr0019-sero-nfkappab
    • idr0021-lawo-pericentriolarmaterial
    • idr0034-kilpinen-hipsci

--conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants