Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for json in emdat transformation. #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for json in emdat transformation. #13

wants to merge 1 commit into from

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

Changes

  • Add utils to support transformation from EMDAT Graphql api extraction.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review January 23, 2025 12:03
emmanuelmathot
emmanuelmathot requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a test scenario with json data sample please

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/add-transform-support-for-json branch from 4a7badf to 77ee932 Compare January 24, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rup-Narayan-Rajbanshi @emmanuelmathot