Use ActiveRecord methods to generate INSERT SQLs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| values.each do |attribute, value| | ||
| column = record.column_for_attribute(attribute.name) | ||
| values[attribute] = connection.type_cast(value, column) | ||
| end |
There was a problem hiding this comment.
I wish this block could be avoided and have that done automatically, but I couldn't figure out how.
There was a problem hiding this comment.
I think it looks alright. It's ok since this code is extracted into its own method.
It might be worth writing some docs for this method/module now that things are getting a little more complicated.
There was a problem hiding this comment.
@nettofarah Done! Let me know if it looks alright.
nettofarah
added a commit
that referenced
this pull request
Dec 7, 2015
Use ActiveRecord methods to generate INSERT SQLs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use Polo with PostgreSQL but ran into couple of issues (I using it from Master with the PR related to Postgres that was merged couple of days ago):
hstore(http://www.postgresql.org/docs/9.4/static/hstore.html), and that wasn't being serialized with the correct syntax.To get that fixed I went ahead and changed the code to use ActiveRecord methods to generate SQL, and after checking it manually, I could see it working fine for both PostgreSQL and MySQL.
The reason why I had to change all SQLs on the specs to be double-quoted is because that is the standard for SQLite, as it only supports backticks to the compatible with MySQL (see https://www.sqlite.org/lang_keywords.html)
I personally believe that these changes really need the work on #23 to be done. And additionally it would be nice to test DBMS specifics, like the different data types each one has (e.g.
hstore,jsonorarrayon PostgreSQL) and different syntaxes. But I'm not sure what would be the best practices to structure and organize those tests.