Skip to content

Commit

Permalink
Fix deployment in githubactions
Browse files Browse the repository at this point in the history
  • Loading branch information
leavauchier committed Jul 16, 2024
1 parent add0ff2 commit b049df7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/cicd_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:
# Also run when the pull request merges (which generates a push)
# So that we can tag the docker image appropriately.
push:
branches: [ "master" ]
tags: [ 'v*.*.*' ]

env:
Expand Down Expand Up @@ -39,6 +38,16 @@ jobs:
${{ env.TEST_TAG }}
python -m pytest ./test -s --log-cli-level DEBUG
# Login against a Docker registry except on PR
# https://github.com/docker/login-action
- name: Log into registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# Extract metadata (tags, labels) for Docker
# https://github.com/docker/metadata-action
- name: Extract Docker metadata
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/cicd_full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ jobs:
test_local:
runs-on: ubuntu-latest
environment:
name: pypi
url: https://pypi.org/p/ign-pdal-tools
permissions:
contents: read
packages: write
Expand Down

0 comments on commit b049df7

Please sign in to comment.