Fix groups api calls #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the RF2 content is loaded into the DB, and BEFORE the tests run
CoderMChu
requested changes
May 17, 2023
There was a problem hiding this comment.
@edeati Thanks for your pull request. Well spotted and thanks for fixing the group api call. This api is not used internally and should have been removed. It would be great if you can split your changes in 3 different PRs. (i.e group api call fix, docker-compose change and azure pipeline)
docker-compose.yml
Outdated
| @@ -31,7 +31,7 @@ services: | |||
| ports: | |||
| - 8081:8081 | |||
| environment: | |||
| - SPRING_DATASOURCE_URL=jdbc:mysql://db:3306/?useSSL=false | |||
| - SPRING_DATASOURCE_URL=jdbc:mysql://db:3306/?useSSL=false&llowLoadLocalInfile=true&allowPublicKeyRetrieval=true | |||
There was a problem hiding this comment.
"llowLoadLocalInfile=true" is missing a (i.e allowLoadLocalInfile=true)
| @@ -21,7 +21,7 @@ services: | |||
| volumes: | |||
| - mysql:/var/lib/mysql | |||
| command: | |||
| mysqld --sql_mode="NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES" --lower_case_table_names=1 | |||
| mysqld --local-infile=ON --sql_mode="NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES" --lower_case_table_names=1 | |||
QuyenLy87
force-pushed
the
develop
branch
2 times, most recently
from
7a8daeb
to
04963b6
Compare
|
It looks as though the actual groups-api-fix part of the PR has already been addressed. The remaining changes have been split out into seperate PRs, as per below. If any of those have similarly been addressed please update.
|
QuyenLy87
force-pushed
the
develop
branch
6 times, most recently
from
6352584
to
d047fec
Compare
QuyenLy87
force-pushed
the
develop
branch
3 times, most recently
from
947fe13
to
c926f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for
groupsapi calls where the api call throws an exception:com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer found for class org.hibernate.proxy.pojo.bytebuddy.ByteBuddyInterceptor and no properties discovered to create BeanSerializer (to avoid exception, disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain: org.ihtsdo.rvf.core.data.model.AssertionGroup$HibernateProxy$PhV4dVWY["hibernateLazyInitializer"])To reproduce this either try to get an existing assertion group with a
GET groups/{id}call or try to add new tests to an assertion group with aPOST groups/{id}/assertions