Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: Add mustache/mustache as dependency #8541

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Nov 29, 2024

This PR adds mustache/mustache as composer dependency.

Usage:

  • Provides templating mechanism for mails, to replace the naive search and replace we have used until now.

Wrapped By:

  • Not applicable, functionality is only used internally in database service and not provided to other ILIAS components.

Reasoning:

  • Mustache is in a good place between expressiveness and ease of use. User testing has shown that typical administrative users can indeed understand mustache easy enough to leverage its power to create mail templates.
  • Mustache is a well standardized templating language that has implementations in many languages. The specs have been stable for a long time.

Maintenance:

  • The library is widely used by many PHP projects. It has 41 contributors, but the most contributions have been made by one person. There is no visible backing from any organisation. There haven't been any releases for over a year.
  • The library doesn't seem to be in a super good place risk wise, but the missing releases could also be just a sign for a stable library for a stable spec. Since Mustache is a standard and widely use spec we can expect other PHP implementations even if this concrete implementation might become unmaintained someday. So the risk seems tolerable.

Links:

@nhaagen nhaagen added the dependencies Pull requests that update a dependency file label Nov 29, 2024
@kergomard
Copy link
Contributor

Dependency is accepted for ILIAS 11. Licence: MIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants