Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: Add ifsnop/mysqldump-php as dependency #8542

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Nov 29, 2024

This PR adds ifsnop/mysqldump-php as composer dependency.

Usage:

  • Provides engine to dump database in standard sql for an export.

Wrapped By:

  • Not applicable, functionality is only used internally in database service and not provided to other ILIAS components.

Reasoning:

  • One could use standard mysqldump-tool via exec instead, but this would introduce an exec call that would be marked during white box sec-analysis.
  • The library offers facilities for filtering data, which could become an extra benefit sometime, e.g. for creating distributable dumps.

Maintenance:

  • The last release of the library was in March '23. There are 45 contributors although most contributions are from two people. There is no obvious backing from some company or organisation. The code is based on some script that is a lot older.
  • This library doesn't seem to be the most reliable on, but since we could easily fall back to standard mysql dumper, the risk seems tolerable.

Links:

@nhaagen nhaagen added the dependencies Pull requests that update a dependency file label Nov 29, 2024
@kergomard
Copy link
Contributor

Dependency is accepted for ILIAS 11. Licence: GPL-3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants