Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: Add seld/jsonlint as dependency #8543

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Nov 29, 2024

This PR adds seld/jsonlint as composer dependency.

Usage:

  • This allows the setup to give more informative error messages regarding the json that is used for config.

Wrapped By:

  • Not applicable, functionality is only used internally in the setup and not provided to other ILIAS components.

Reasoning:

  • The PHP json parser does not give information where a given json is faulty. This degrades user experience since we can only say "your json is wrong" but not where the actual error is located.

Maintenance:

  • The library received its last update in July '24. It seems to be feature complete, though.
  • The maintainer Jordi Boggiano works on packagist and composer and is a well known person in the PHP community.
  • The functionality provided by this library is not super important but more for quality of life. We could easily decide to ditch the library if any problems arise.

Links:

@nhaagen nhaagen added the dependencies Pull requests that update a dependency file label Nov 29, 2024
@klees
Copy link
Member

klees commented Dec 9, 2024

License is GPLv3.

@klees
Copy link
Member

klees commented Dec 9, 2024

License is MIT.

@kergomard
Copy link
Contributor

Dependency is accepted for ILIAS 11. Licence: MIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants