Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: add pimple/pimple as dependency #8545

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Nov 29, 2024

This PR adds pimple/pimple as composer dependency.

Usage:

  • Provides the dependency injection container that is used as a service locator throughout the system.
  • Will most likely be used as the DIC solution for the new initialisation scheme introduced with the component revision.

Wrapped By:

  • ILIAS\DI\Container

Reasoning:

  • Pimple provides a light weight and simple dependency injection container, which is yet quite powerful. The interface is modelled along \ArrayAccess, hence it can be easily mocked for testing.
  • Dependency injection is ILIAS' future way to express dependencies between services and components.

Maintenance:

  • The library has been stable for a long time and didn't receive updates since 2021.
  • The actual code is only about 150 LOC and hence could be easily maintained by us, if necessary.

Links:

@nhaagen nhaagen added the dependencies Pull requests that update a dependency file label Nov 29, 2024
@kergomard
Copy link
Contributor

Dependency is accepted for ILIAS 11. Licence: MIT.

@klees
Copy link
Member

klees commented Dec 9, 2024

License is MIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants