Badge/User: Improve toggling hidden badges in public profile #8846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kergomard A review of the changes in "User" is highly appreciated. Of course it is still ugly that the "Badge" component has to ...
But as long as the public profile did not offer any kind of "Slot System" for other compoents, this PR at least ...
|
mjansenDatabay
force-pushed
the
hotfix/10/43589
branch
3 times, most recently
from
b82015d to
ef4e076
Compare
mjansenDatabay
force-pushed
the
hotfix/10/43589
branch
from
ef4e076 to
3389e60
Compare
kergomard
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Thank you very much @mjansenDatabay ! This looks far cleaner even though you are right, that there is still quite some room for improvement, ...but for this I would need to put some work in, so it is not on you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=43589
If approved, this has to be picket to
trunk.