Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing acceleration state in SIL #299

Open
mwlock opened this issue Oct 9, 2023 · 3 comments
Open

Missing acceleration state in SIL #299

mwlock opened this issue Oct 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@mwlock
Copy link

mwlock commented Oct 9, 2023

Regarding the (SIL) simulation backend, it seems that the acceleration is not yet implemented.

# TODO: state technically also has acceleration, but sim_data_types does not

How critical is this to the onboard controllers?

@whoenig whoenig added the enhancement New feature or request label Oct 9, 2023
@whoenig
Copy link

whoenig commented Oct 9, 2023

I don't think any of the onboard controllers use this information. Feedback is on position and velocity, only.

@knmcguire
Copy link
Collaborator

Hi! Acceleration is indeed not really used indeed for PID or mellinger, but the INDI implementation does rely on it so it might be using that information.

@mwlock
Copy link
Author

mwlock commented Oct 10, 2023

Thank you for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants