The Rayleigh Scattering is not correct. #412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.s. I think I raised this issue a few years ago, but it didn't get fixed, so it might be worth propagating this correction to all other branches to make sure that it doesn't somehow get overwritten in future? |
|
Yes, you're absolutely right. Not only this but also, everywhere we use this function, we use it as scattering coefficient instead of the reduced scattering. We're directly testing certain scattering coefficients, so the tests shouldn't break. It seems like some builds don't run at the moment, which is a different problem, though 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your formula for Rayleigh scattering used to be ~ (lambda) ^ (1e-4), but should be ~ (lambda)^-4
I put the pull request in by just editing the GitHub text file, so haven't rerun the tests, but I can't see why this should break anything. If you have any optical tests that validate light fluence values etc, then these will need remaking I suspect.