T417 Adding possibility of wavelength-dependant laser energy #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremieglt
changed the title
jeremieglt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
Code review
The only modifications were made in the optical_adapter_base.py (adding possibility of selecting mutiple laser energies dependant on the wavelengths) and tags.py (modification of the description of the LASER_PULSE_ENERGY_IN_MILLIJOULE tag). There is also an addition of a test file (see next section).
Testing requirements
The tests specific to this modification were written under : simpa/simpa_tests/automatic_tests/test_laser_energy.py. They ensure that all formats are possible for entering the laser energy.
Additional context
Calibration study at iThera Medical with MSOT Acuity revealed that simulating with wavelength dependant laser energy could refine the simulation precision without any additional additional computing cost.
Issue fixed
Fixes feature request #417