Handle RemoveTextDefinition (#720)

* Handle `RemoveTextDefinition`

* formatted

* formatted

* formatted

* added old value

* added back remove defn column

* corrected syntex

* changed defn

src/oaklib/implementations/simpleobo/simple_obo_implementation.py

@@ -861,7 +861,7 @@ def _tv_dict(stanza: Stanza) -> Dict[str, List[str]]:
                         id=_id(), about_node=t1id, new_value=td2, old_value=td1
                     )
                 elif vals1:
-                    yield kgcl.RemoveTextDefinition(id=_id(), about_node=t1id)
+                    yield kgcl.RemoveTextDefinition(id=_id(), about_node=t1id, old_value=td1)
                 else:
                     yield kgcl.NewTextDefinition(id=_id(), about_node=t2id, new_value=td2)
             elif tag == TAG_IS_OBSOLETE:

src/oaklib/interfaces/differ_interface.py

@@ -28,6 +28,7 @@
     PredicateChange,
     RemoveNodeFromSubset,
     RemoveSynonym,
+    RemoveTextDefinition,
     SynonymPredicateChange,
 )
 
@@ -250,6 +251,15 @@ def diff(
                 )
                 yield new_def
 
+            # definition removal
+            if self.definition(entity) is not None and other_ontology.definition(entity) is None:
+                yield RemoveTextDefinition(
+                    id=_gen_id(),
+                    about_node=entity,
+                    old_value=self.definition(entity),
+                    new_value=other_ontology.definition(entity),
+                )
+
             # Synonyms - compute both sets of aliases
             self_aliases[entity] = set(self.alias_relationships(entity, exclude_labels=True))
             other_aliases[entity] = set(
@@ -335,7 +345,9 @@ def diff(
 
         # Process the entities in parallel using a generator
         yield from _parallely_get_relationship_changes(
-            self_ontology_without_obsoletes, self_out_rels, other_out_rels,
+            self_ontology_without_obsoletes,
+            self_out_rels,
+            other_out_rels,
         )
 
     def diff_summary(

src/oaklib/utilities/writers/change_handler.py

@@ -253,6 +253,15 @@ def handle_new_text_definition(self, value):
         header = "| Term | New Text Definition |"
         self.write_markdown_table(f"Text definitions added: {len(rows)}", header, rows)
 
+    def handle_remove_text_definition(self, value):
+        # Create rows for the table
+        rows = [
+            f"| {self._format_entity_labels(change.about_node)} | {change.old_value} |"
+            for change in value
+        ]
+        header = "| Term | Removed Text Definition |"
+        self.write_markdown_table(f"Text definitions removed: {len(rows)}", header, rows)
+
     def handle_node_obsoletion_with_direct_replacement(self, value):
         rows = [
             f"| {self._format_entity_labels(change.about_node)} |\
@@ -338,6 +347,7 @@ def process_changes(self, curie_or_change: Dict[str, Change]):
             "ClassCreation": self.handle_class_creation,
             "NodeDeletion": self.handle_node_deletion,
             "NewTextDefinition": self.handle_new_text_definition,  # ! same as NodeTextDefinition
+            "RemoveTextDefinition": self.handle_remove_text_definition,
             "NodeObsoletionWithDirectReplacement": self.handle_node_obsoletion_with_direct_replacement,
             "NodeObsoletion": self.handle_node_obsoletion,
             "NodeDirectMerge": self.handle_node_direct_merge,