Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using semsimian v0.1.18 that writes output directly rather than using oaklib to write output #609

Closed
wants to merge 40 commits into from
Closed

Using semsimian v0.1.18 that writes output directly rather than using oaklib to write output #609

wants to merge 40 commits into from

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Jul 11, 2023 •
edited
Loading

TODO

  • Remove rc version anchoring of semsimian (done for testing purposes).

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 79.16% and project coverage change: -0.01% ⚠️

Comparison is base (f7b8819) 76.96% compared to head (2882d3b) 76.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   76.96%   76.95%   -0.01%     
==========================================
  Files         247      247              
  Lines       28576    28591      +15     
==========================================
+ Hits        21993    22002       +9     
- Misses       6583     6589       +6
Files Changed Coverage Δ
src/oaklib/cli.py 58.02% <76.19%> (-0.03%) ⬇️
src/oaklib/datamodels/vocabulary.py 100.00% <100.00%> (ø)
src/oaklib/utilities/table_filler.py 78.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrshdhgd hrshdhgd changed the title Using semsimian v0.1.17-rc2 that writes output directly rather than using oaklib to write output Using semsimian v0.1.17-rc3 that writes output directly rather than using oaklib to write output Jul 14, 2023
@hrshdhgd hrshdhgd changed the title Using semsimian v0.1.17-rc3 that writes output directly rather than using oaklib to write output Using semsimian v0.1.17-rc4 that writes output directly rather than using oaklib to write output Jul 15, 2023
@hrshdhgd hrshdhgd changed the title Using semsimian v0.1.17-rc4 that writes output directly rather than using oaklib to write output Using semsimian v0.1.17-rc6 that writes output directly rather than using oaklib to write output Jul 21, 2023
@hrshdhgd hrshdhgd changed the title Using semsimian v0.1.17-rc6 that writes output directly rather than using oaklib to write output Using semsimian v0.1.18 that writes output directly rather than using oaklib to write output Jul 25, 2023
@hrshdhgd hrshdhgd marked this pull request as ready for review July 25, 2023 20:40
@hrshdhgd hrshdhgd requested a review from cmungall July 25, 2023 20:41
hrshdhgd
hrshdhgd commented Jul 25, 2023
View reviewed changes
src/oaklib/cli.py Outdated Show resolved Hide resolved
@hrshdhgd hrshdhgd removed the request for review from cmungall July 25, 2023 21:16
@hrshdhgd hrshdhgd marked this pull request as draft July 25, 2023 21:16
@hrshdhgd
Copy link
Collaborator Author

hrshdhgd commented Jul 25, 2023 •
edited
Loading

In addition to existing params, introduce a new CLI param named --config *.yaml which would have values for:

  • low_memory
    etc.
low_memory: true

and so on.

@hrshdhgd
Copy link
Collaborator Author

Irrelevant now due to #645

@hrshdhgd hrshdhgd closed this Aug 28, 2023
@hrshdhgd hrshdhgd deleted the experimental-semsimian branch August 28, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to pass a limited closure table to semsimian
2 participants
@hrshdhgd @codecov-commenter