-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK dependency tuning #686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 76.48% 76.48%
=======================================
Files 252 252
Lines 29386 29386
=======================================
+ Hits 22475 22477 +2
+ Misses 6911 6909 -2 ☔ View full report in Codecov by Sentry. |
pyproject.toml
Outdated
@@ -37,7 +35,7 @@ pysolr = "^3.9.0" | |||
eutils = ">=0.6.0" | |||
requests-cache = "^1.0.1" | |||
click = "*" | |||
semsimian = "0.2.1" | |||
semsimian = ">=0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I favor less pinning but given how tightly coupled these are, I think limiting to 0.2.*
may be sensible? See also Mark's Q in #oak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, switched to ^0.2.1
. As per Mark's Q, I did read it and it was confusing with the versions he mentioned.
@@ -26,6 +26,7 @@ deps = | |||
coverage | |||
semsimian | |||
gilda | |||
linkml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit worried about duplication of dependency metadata but I don't quite understand why these are in tox.ini in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because if we run tox -e py
(to run pytest via tox), it throws errors about linkml module not found (in tot's virtual environment). It doesn't affect poetry
and it's working in general. We could do away with tox
and be solely poetry
dependent but we've had those conversations in the past.
Addresses comment on Improve usage of SSSOM-py #666
Addresses Check dependencies in pyproject.toml #323
Limited
sssom
to < 0.4.0Removed unnecessary
sssom-schema
dependency since it is satisfied bysssom
itself.Removed
lark
dependency (Unsure how it got in there)Added
linkml
as a dependency in tox for running tests.Removed
semsimian
fixed version dependency.