VSKit - description newline replacement #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSKit generates "descriptions" for LinkML from ontologies. Sometimes, those descriptions contain newline characters. These newline characters break downstream LinkML tooling such as the Pydantic generator.
I believe that it is appropriate to replace those newline characters with spaces at this point in the flow.
An example of this newline phenomenon is the permissible value IP-seq from EFO:
Which does not look the same as, for example, its rendering on EBI
https://www.ebi.ac.uk/ols4/ontologies/efo/classes?short_form=EFO_0005032