Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flake8 and replace it by ruff #716

Merged
merged 17 commits into from
Mar 14, 2024
Merged

Remove flake8 and replace it by ruff #716

merged 17 commits into from
Mar 14, 2024

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Mar 14, 2024

  • Accommodate for score_metric for search and termset_pairwise_similarity
  • Replaced flake8 by ruff
    • Reason: We're moving away from flake8 and embracing ruff in all our cookiecutters and hence all projects.
    • ruff includes most rules flake8 enforces and some more.

@hrshdhgd hrshdhgd changed the title Accommodate for score_metric for search and `termset_pairwise_simil… Accommodate for score_metric for search and termset_pairwise_similarity Mar 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 69.64286% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 75.46%. Comparing base (9d05234) to head (87fc65e).

Files Patch % Lines
...mentations/translator/translator_implementation.py 20.00% 4 Missing ⚠️
src/oaklib/selector.py 25.00% 3 Missing ⚠️
tests/test_cli.py 88.23% 2 Missing ⚠️
src/oaklib/cli.py 50.00% 1 Missing ⚠️
...b/implementations/ncbi/ncbi_gene_implementation.py 66.66% 1 Missing ⚠️
...c/oaklib/implementations/ols/ols_implementation.py 50.00% 1 Missing ⚠️
...ib/implementations/pronto/pronto_implementation.py 0.00% 1 Missing ⚠️
...lementations/semsimian/semsimian_implementation.py 0.00% 1 Missing ⚠️
...oaklib/implementations/sqldb/sql_implementation.py 0.00% 1 Missing ⚠️
...aklib/interfaces/association_provider_interface.py 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         268      268           
  Lines       31317    31327   +10     
=======================================
+ Hits        23632    23640    +8     
- Misses       7685     7687    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrshdhgd hrshdhgd changed the title Accommodate for score_metric for search and termset_pairwise_similarity Remove flake8 since py3.12 gives some weird errors Mar 14, 2024
@hrshdhgd hrshdhgd changed the title Remove flake8 since py3.12 gives some weird errors Remove flake8 and replace it by ruff Mar 14, 2024
@hrshdhgd hrshdhgd requested a review from cmungall March 14, 2024 21:32
@hrshdhgd hrshdhgd marked this pull request as ready for review March 14, 2024 21:32
@hrshdhgd hrshdhgd merged commit a519291 into main Mar 14, 2024
9 checks passed
@hrshdhgd hrshdhgd deleted the score-metric branch March 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants