Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient simple obo diffs #719

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

cmungall
Copy link
Collaborator

@cmungall cmungall commented Mar 18, 2024

  • Adding a more efficient diff implementation for simpleobo
    • technically this is a violation of the DRY principle but one of the goals of the interface/impl split is to allow implementations to do custom implementations that may be faster
  • Undoing some of Create release notes markdown output for diff command #605

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.07547% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (5dcedf5) to head (32bb849).

Files Patch % Lines
src/oaklib/io/streaming_markdown_writer.py 3.70% 26 Missing ⚠️
src/oaklib/cli.py 22.22% 14 Missing ⚠️
...ementations/simpleobo/simple_obo_implementation.py 90.97% 12 Missing ⚠️
tests/test_implementations/__init__.py 45.45% 12 Missing ⚠️
src/oaklib/interfaces/differ_interface.py 83.63% 9 Missing ⚠️
src/oaklib/utilities/mapping/mapping_validation.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   75.45%   75.52%   +0.07%     
==========================================
  Files         268      268              
  Lines       31328    31429     +101     
==========================================
+ Hits        23638    23738     +100     
- Misses       7690     7691       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 4f5e1cb into main Mar 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants