Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synonymizer refactor2 #728

Merged
merged 3 commits into from
Mar 28, 2024
Merged

synonymizer refactor2 #728

merged 3 commits into from
Mar 28, 2024

Conversation

cmungall
Copy link
Collaborator

  • synonymizer refactoring.
  • Command line

Moving synonymizer from mapping rules to its own data model.
Moving logic from CLI to utils
@cmungall cmungall requested a review from hrshdhgd March 28, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 75.46%. Comparing base (8da76e1) to head (37f49ed).
Report is 2 commits behind head on main.

Files Patch % Lines
src/oaklib/datamodels/synonymizer_datamodel.py 79.18% 51 Missing ⚠️
src/oaklib/cli.py 80.00% 7 Missing ⚠️
src/oaklib/utilities/lexical/synonymizer.py 96.55% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #728    +/-   ##
========================================
  Coverage   75.46%   75.46%            
========================================
  Files         272      275     +3     
  Lines       31875    32189   +314     
========================================
+ Hits        24056    24293   +237     
- Misses       7819     7896    +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 06f1220 into main Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants