Make sure SPARQL checks cover the entire ontology. #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROBOT's `verify` command does not follow OWL Import declarations, so the checks it performs only applies strictly to the file it is given as input. Components and pattern-derived definitions are part of the "local" ontology and should be covered by the SPARQL checks, and we ensure they are by running the `verify` command on the `$(SRCMERGED)` intermediate file, in which components and pattern-derived definitions (basically all files listed in $(OTHER_SRC)`) are explicitly merged (but _not_ ODK imports). closes #1154
matentzn
reviewed
Dec 12, 2024
matentzn
previously approved these changes
Dec 12, 2024
Co-authored-by: Nico Matentzoglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROBOT's
verifycommand does not follow OWL Import declarations, so the checks it performs only applies strictly to the file it is given as input.Components and pattern-derived definitions are part of the "local" ontology and should be covered by the SPARQL checks, and we ensure they are by running the
verifycommand on the$(SRCMERGED)intermediate file, in which components and pattern-derived definitions (basically all files listed in $(OTHER_SRC)`) are explicitly merged (but not ODK imports).closes #1154