Update cell_by_location.rq #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to be more generic
gouttegd
approved these changes
Dec 18, 2023
switched to union of part_of and has_soma_location
balhoff
requested changes
Jan 5, 2024
| #+ summary: Find cells by location | ||
| #+ description: Enter an anatomical location, get back a list of cell type IRIs and labels | ||
| #+ summary: Find cells by type and location | ||
| #+ description: Args: cell: the iri or a cell type; location: the iri of an anatomical location. All args are optional. With no args returns all cells with an anatomical location. Location is a union of part_of (suitable for location of most cells) and has_soma_location (used for neurons). This pattern is designed for safe grouping of cell annotations. Returns: a 2 column table: cell (type) IRIs and cell (type) labels. |
There was a problem hiding this comment.
Suggested change
| #+ description: Args: cell: the iri or a cell type; location: the iri of an anatomical location. All args are optional. With no args returns all cells with an anatomical location. Location is a union of part_of (suitable for location of most cells) and has_soma_location (used for neurons). This pattern is designed for safe grouping of cell annotations. Returns: a 2 column table: cell (type) IRIs and cell (type) labels. | |
| #+ description: Args: cell: the iri of a cell type; location: the iri of an anatomical location. All args are optional. With no args returns all cells with an anatomical location. Location is a union of part_of (suitable for location of most cells) and has_soma_location (used for neurons). This pattern is designed for safe grouping of cell annotations. Returns: a 2 column table: cell (type) IRIs and cell (type) labels. |
Comment on lines
+16
to
20
| { | ||
| ?cell_iri part_of: ?_location_iri . | ||
| } UNION { | ||
| ?cell_iri has_soma_location: ?someValue . | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| ?cell_iri part_of: ?_location_iri . | |
| } UNION { | |
| ?cell_iri has_soma_location: ?someValue . | |
| } | |
| ?cell_iri part_of:|has_soma_location: ?_location_iri . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to be more generic.
My aim is a generic cells by type/location query. The default option with no location does depend on all cell types being part of some anatomical entity though. I think would be OK to add this at the root of CL. Note that bodily fluids and excreta are anatomical entities (Can add that request to CL).