Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-head modifications #14

Open
MirandaEcho opened this issue May 20, 2020 · 5 comments
Open

Sub-head modifications #14

MirandaEcho opened this issue May 20, 2020 · 5 comments

Comments

@MirandaEcho
Copy link

Should the subhead be overlaid on the cover photo? Yes, for the full page photos, the subhead should be on top of the photo, as in the NYT example.
Does the theme already have this function? Not sure if the theme already has that function. For stories with a regular sized feature photo, the subhead should be below the headline, as in this example:
https://www.nytimes.com/2020/04/28/nyregion/nurses-coronavirus.html?action=click&module=Top%20Stories&pgtype=Homepage. I would like the option to not have a subhead on all stories also.

@benlk
Copy link
Collaborator

benlk commented May 21, 2020

Parts of this:

@MirandaEcho
Copy link
Author

Note: She is currently using Gutenberg (I believe) to add subheads to the current template, so this doesn't need to be added there, but I will clarify with her after she reviews this on the new template to see if she wants this functionality there instead.

@benlk
Copy link
Collaborator

benlk commented May 22, 2020

The subtitle meta box will be in the post editor no matter which template is used.

@benlk benlk added the question label May 26, 2020
@MirandaEcho
Copy link
Author

@benlk what is the question on this one?

@benlk
Copy link
Collaborator

benlk commented May 27, 2020

The question is/was: With 2h remaining in this ticket, should we make the meta box work in Gutenberg?

But based on what you've said about them using Gutenberg, we'll need to do that anyways, so no question remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants