Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metabox and other functions for subhead #19

Merged
merged 10 commits into from
Jun 3, 2020
Merged

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 22, 2020

Changes

This pull request makes the following changes:

  • adds a meta box for the subtitle
  • provides a version of the solution for this problem in Largo (Bring the subtitle/subhead/dek meta box into Largo WPBuddy/largo#1730) that doesn't involve reliance on Largo's functions, because this is not a Largo child theme.
  • tests the subtitle output on posts with $subtitle = get_post_custom_values( 'subtitle', get_the_ID() );

Screen Shot 2020-06-02 at 23 22 50
Screen Shot 2020-06-02 at 23 29 01

No styles are included here; I'm waiting until #21 and the firmed-up subtitle styles from that.
Screen Shot 2020-06-02 at 23 24 18

Why

For #14, as a version of WPBuddy/largo#1730 that doesn't depend upon Largo

Testing/Questions

Features that this PR affects:

  • Editor for posts, in Gutenberg and Classic
  • Single post template

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Should we try to allow some HTML in the subtitle?

Steps to test this PR:

  1. edit a post's subtitle, click "Update" or "Save".

@benlk benlk added this to the CALH-001 milestone May 22, 2020
@benlk benlk requested a review from joshdarby May 22, 2020 20:07
@benlk benlk self-assigned this May 22, 2020
@benlk
Copy link
Collaborator Author

benlk commented May 22, 2020

Nonce check is currently not passing in the Classic editor.

@benlk benlk marked this pull request as ready for review June 3, 2020 03:32
Copy link

@joshdarby joshdarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! 👍

@benlk benlk merged commit 1086164 into staging Jun 3, 2020
@benlk benlk deleted the 14-subhead-functions branch June 3, 2020 16:56
@benlk benlk mentioned this pull request Sep 17, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants