Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3780 largo 0.6.4 #13

Merged
merged 6 commits into from
Aug 14, 2019
Merged

3780 largo 0.6.4 #13

merged 6 commits into from
Aug 14, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jul 26, 2019

Changes

This pull request makes the following changes:

Why

For https://secure.helpscout.net/conversation/875863075/3780/

Testing/Questions

Features that this PR affects:

  • pretty much the whole darn site

Questions that need to be answered before merging:

  • are they using custom css?

Work through the child theme checklist: https://github.com/INN/docs/blob/master/checklists/child-themes.md

  • Make sure that the site loads without PHP errors on Vagrant
  • What about these locations? common url
    • Homepage /
    • Articles /?p=1234
    • Series /series/slug/ /?series=1234
    • Category archive pages /category/slug/
    • Series archive pages /series/slug/
    • Series landing pages /slug/
    • Search results /?s=words
    • Pages /slug/
    • Tag archives /tag/slug
  • Load More Posts
    • Did you define a custom archive template?
    • Does the custom archive template load the correct partial when the Load More Posts button is clicked?
  • Styles?
    • Sticky nav
      • Mobile
      • Desktop
    • Non-sticky nav
    • Widgets
    • Article
      • Social buttons
      • Type
      • Fonts rendered are fonts specified in stylesheet ( In Chrome: "Inspect element" on a <p>, then look at the bottom of the "Computed" tab. )
      • Images
    • Footer

@benlk
Copy link
Collaborator Author

benlk commented Aug 14, 2019

Approved in https://secure.helpscout.net/conversation/875863075/3780/?folderId=1211654, with a note that we'll fix WPBuddy/largo#1773 in Largo in the future

@benlk benlk merged commit 80fd0d5 into staging Aug 14, 2019
@benlk benlk deleted the 3780-largo-0.6.4 branch August 14, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant