Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rollout_iterations and lead_time_hours params in module #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

14renus
Copy link
Collaborator

@14renus 14renus commented Jan 28, 2025

rollout_iterations:

  • explicitly set rollout_iterations for train, val, test in module configs
  • set dataset multistep based on this

lead_time_hours:

  • explicitly set in dataset config
  • set module lead_time_hours based on this for correct metric logging

Ideally though, metrics to log are configurable and the arg lead_time_hours for metric logging is handled separately

@14renus 14renus requested a review from gcouairon January 28, 2025 12:47
@14renus 14renus requested a review from a team as a code owner January 28, 2025 12:47
@14renus 14renus linked an issue Jan 28, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lead time in evaluation metrics
1 participant