ENH Add python code for notebook used in the Pipeline video
#494
Conversation
There was a problem hiding this comment.
LGTM. I assume that the goal of keeping this notebook is to:
- make it possible to point the users who ask for just in case they want to reproduce it locally,
- archive the script in the event we want to rerecord this video with an update in the UI of of scikit-learn in a future release.
But it should not be included in the Table of Content of the jupyter book or the navigation menus of FUN.
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
|
Done, thanks! |
…t-learn-mooc into video_pipeline
jupyter-book/predictive_modeling_pipeline/03_categorical_pipeline_video.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Grisel <[email protected]>
jupyter-book/predictive_modeling_pipeline/03_categorical_pipeline_video.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Grisel <[email protected]>
I can start embedding the videos on the rest of the slides but I may need help |
|
The progress bar is not showing, do you think it is just hidden because of the size of the video, @ogrisel ? |
Yes, because if the iframe css in |
Please do so and I will open a PR to fix the CSS next week. |
|
Let's merge and iterate in other PRs. |
…eo (#494) Co-authored-by: Olivier Grisel <[email protected]> 5eafcd3
Fixes #465.
I think the best place for the video would be somewhere between Exercise M1.05 and the first wrap-up quiz.
The idea is that the video and notebook will be displayed simultaneously within a split webpage. This may require FUN changes.