Skip to content

Test improvements #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 28, 2015
Merged

Test improvements #14

merged 12 commits into from
Apr 28, 2015

Conversation

rliebz
Copy link
Contributor

@rliebz rliebz commented Apr 20, 2015

Changes

  • Add methods for creating/deleting dataverses
  • Switch tests to use a temporary dataverse
  • Silence urllib3 warnings
  • Remove relative pathing from tests
  • Switch to py.test for testing
  • Switch to py.test style asserts
  • Improve documentation
  • Remove unnecessary connected boolean from Connection (Connection will throw an exception if it doesn't connect successfully)
  • Move data refreshing logic for getting datasets
  • Allow metadata updating to resolve Support editing the metadata of a dataset using JSON #15

Side Effects

  • By default, getting a dataset/datasets won't make a request to the server if one has already been made. This is a change from current behavior, but more closely resembles logic for getting Dataverses.
    • The list of datasets on a dataverse will be refreshed automatically by a request to the server every time a dataset is added or deleted.
  • add_dataset has been replaced with create_dataset to improve consistency across the client.

rliebz added 11 commits April 16, 2015 11:33
@rliebz
Switch to pytest and remove relative pathing
9c20ebf
@rliebz
Switch to pytest-style asserts
5844d26
@rliebz
Allow dataverse creation/deletion
e1e54eb
@rliebz
Use temporary Dataverse for tests, improve test variable names
b95a5f8
@rliebz
Silence urllib3 warnings
e1b9198
@rliebz
Add tests for creating and deleting dataverses
bbd4b45
@rliebz
Prefer single quotes and PEP8 improvements
6d5fe68
@rliebz
Move data refreshing logic for getting datasets. Changes default beha…
381a7f8 
…vior
@rliebz
Refactor getting service document and add Connection tests
f307d7c
@rliebz
Improve consistency of client
34bbbfe
@rliebz
Add metadata updating and improve metadata handling
09cb398 
 - Dataset `_json` and `_get_json` renamed to `_metadata` and `_get_metadata`
 - Improve logic behind updating metadata for various versions
 - Raise appropriate error for publishing datasets in unpublished dataverses
 - Remove `delete_all_files` method (This should not be a one-line operation)
@rliebz rliebz mentioned this pull request Apr 27, 2015
Closed
rliebz added a commit that referenced this pull request Apr 28, 2015
@rliebz
Merge pull request #14 from IQSS/test-improvements
096c496 
Improve consistency, usability, tests, and documentation.
@rliebz rliebz merged commit 096c496 into master Apr 28, 2015
@rliebz rliebz deleted the test-improvements branch April 28, 2015 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support editing the metadata of a dataset using JSON
1 participant
@rliebz