Added possibilty to switch ssl verification off #38
Conversation
There was a problem hiding this comment.
@dwintergruen you seem to be reverting e17d8f9 which is a fix for IQSS/dataverse#3326 . Is this intentional?
dataverse/file.py
Outdated
| name = json['datafile']['name'] | ||
| file_id = json['datafile']['id'] | ||
| name = json['datafile']['name'] | ||
| file_id = json['datafile']['id'] |
There was a problem hiding this comment.
@dwintergruen you seem to be reverting e17d8f9 which is a fix for IQSS/dataverse#3326 . Is this intentional?
|
No I haven’t realized this change.
|
|
@dwintergruen ok, can you please update your pull request? Thanks!! |
|
Just adding a +1 for fixing this issue. I'm having problems with exactly this. |
| @@ -311,19 +319,19 @@ def upload_file(self, filename, content, zip_files=True): | |||
| } | |||
|
|
|||
| requests.post( | |||
| self.edit_media_uri, | |||
| self.edit_media_uri.replace("https","http"), | |||
There was a problem hiding this comment.
I'm confused. With this "replace" is the fix actually to switch from https to http? This reminds me of IQSS/dataverse#5656 where we recently starting allowing http (not recommended) instead of https for password resets. We hope that this non-https configuration is only used for a test server!
Helps testing on self-signed servers.