Skip to content

Commit

Permalink
fix: loading layout of results and sort button
Browse files Browse the repository at this point in the history
  • Loading branch information
ekraffmiller committed Dec 17, 2024
1 parent 510c60d commit 0eaebdc
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,28 +100,28 @@ export const ItemsList = forwardRef(
{areItemsAvailable && (
<>
<header>
{isLoadingItems ? (
<SkeletonTheme>
<Skeleton height={19} width={190} />
</SkeletonTheme>
) : (
<Row>
<Col>
<Row>
<Col>
{isLoadingItems ? (
<SkeletonTheme>
<Skeleton height={19} width={190} />
</SkeletonTheme>
) : (
<PaginationResultsInfo
paginationInfo={paginationInfo}
accumulated={accumulatedCount}
/>
</Col>
<Col className={styles['sort-button']}>
<ItemsSortBy
isLoadingCollectionItems={isLoadingItems}
currentSortType={sortSelected}
currentSortOrder={orderSelected}
currentSearchText={searchText}
onSortChange={onSortChange}></ItemsSortBy>
</Col>
</Row>
)}
)}
</Col>
<Col className={styles['sort-button']}>
<ItemsSortBy
isLoadingCollectionItems={isLoadingItems}
currentSortType={sortSelected}
currentSortOrder={orderSelected}
currentSearchText={searchText}
onSortChange={onSortChange}></ItemsSortBy>
</Col>
</Row>
</header>

<ul data-testid="items-list">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export function ItemsSortBy({
title={t('sort.title')}
id="collection-items-sort"
variant="secondary"
disabled={isLoadingCollectionItems}
onSelect={handleSortChange}>
{Object.values(sortOptions).map((sortByOption) => (
<DropdownButtonItem
Expand Down

0 comments on commit 0eaebdc

Please sign in to comment.