-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render Json-LD in Dataset Page #412
base: develop
Are you sure you want to change the base?
Conversation
It would be nice for beta to only run merged code but whatever works for now! Maybe we need an alpha server. 😄 |
@pdurbin yes, I agree we don't want to do this generally, I just wanted to deploy this to beta so that we could run google rich results, to test that the json-ld is readable in the page. We did the test, and found out that the containerized dataverse image runs with robots.txt disallowing all access. So that is the next thing to figure out for this ticket :) |
I created a Dataverse issue for customizing robots.txt: IQSS/dataverse#10593 |
What this PR does / why we need it:
Adds json-ld to header of View Dataset page.
Which issue(s) this PR closes:
Closes #350
Special notes for your reviewer:
This PR is a proof of concept, to test that the json-ld is available in a deployed app. The json-ld is viewable in the browser view of the DOM, and has dynamic data based on the current dataset, but we need to test on a webpage that can be run in https://search.google.com/test/rich-results
Suggestions on how to test this:
Deploy to beta.dataverse.org and do the rich-results test.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: