-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/561 add collection sort #573
Open
ekraffmiller
wants to merge
13
commits into
feat/562-add-collection-facets
Choose a base branch
from
feat/561-add-collection-sort
base: feat/562-add-collection-facets
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/561 add collection sort #573
ekraffmiller
wants to merge
13
commits into
feat/562-add-collection-facets
from
feat/561-add-collection-sort
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
force-pushed
the
feat/561-add-collection-sort
branch
from
December 18, 2024 19:36
73d67d6
to
683b587
Compare
ekraffmiller
added
SPA.Q4.1
Collection Page: All Filtering Options
Size: 3
A percentage of a sprint. 2.1 hours.
labels
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GREI Re-arch
GREI re-architecture-related
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q4.1
Collection Page: All Filtering Options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the Sort button to the Collection page, for sorting collection items.
Which issue(s) this PR closes:
Special notes for your reviewer:
In the Story and the ItemsSortBy component test, the style is not being applied to the selected option, even though it works in the app and in the CollectionItemsPanel Story.
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
http://localhost:8000/spa/collections
, check that the Sort button has ' Newest' highlighted, and the 'Relevance' sort option doesn't exist.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: