-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataciteXML changes Plus RelationType field #10632
Merged
landreev
merged 122 commits into
IQSS:develop
from
QualitativeDataRepository:datacite_plus_relPubRelType
Sep 23, 2024
Merged
Changes from 2 commits
Commits
Show all changes
122 commits
Select commit
Hold shift + click to select a range
4878cfe
separate metadata parsing/params from XML generation code
qqmyers 68792c2
extract some common xml writing util code
qqmyers 1a46155
note duplicate method
qqmyers ace656c
remove xml template doc, refactor to generate xml, adding OA fields
qqmyers dba03e2
refactor source of XML info
qqmyers af3e24b
add code to get raw alphanumeric pid value
qqmyers fa23884
remove duplicate method
qqmyers 0d22d6c
dates, resourceType, alternate Ids
qqmyers d69bf41
more methods
qqmyers 04b367f
only one field to look for
qqmyers 003431d
use common util method
qqmyers fea2f5e
access rights descriptions, geolocations, funding refs
qqmyers 3c52b6a
altTitles npe
qqmyers bab2a0d
fixes and test
qqmyers 3cca63d
fix for empty rel pub entry
qqmyers 30c80a9
bugs: remove bad nesting, dupe values
qqmyers a2acdeb
add XML Validation to test
qqmyers 3ec7a0b
fix contributorType
qqmyers 842dee6
add geolocations element and multiple geolocation
qqmyers 81a7c4a
typos
qqmyers ed5eab0
try execute inside the main method
qqmyers 39673f0
Fix subject, keyword
qqmyers 36097d6
fix geo coverage
qqmyers a5d3b3e
adjust funders to include grant number, add xml escaping for description
qqmyers 8a12444
bug: add dataset descriptions
qqmyers f3e5dc1
typo, add xml escape for funder
qqmyers 5610c95
still typo
qqmyers 7148b03
mark contact as deprecated - unused
qqmyers 0470459
more fixes
qqmyers c0265da
catch parseexception
qqmyers 2ff8678
fix alternateIdentifier, related PID parsing, series
qqmyers 182f3d7
catch PID update exception to avoid corrupt dataset
qqmyers be90355
try long sleep
qqmyers e458e8c
set dv released before pid publicize, go back to short time
qqmyers 27fe7b4
always use latest version for copy
qqmyers 00a3830
handle deaccession, fix relatedIDtype for files
qqmyers 1faf0cd
missed assignment for title
qqmyers 23dd581
fix creator for deaccessioned
qqmyers 3bbd2e9
correct fix for creators when deaccessioned
qqmyers 4def6da
remove bad value and lang
qqmyers eac477e
add creatorName sub element for deaccession/no names case
qqmyers 154ac8a
typo
qqmyers 9144f6c
fix resourceType - always 1 entry
qqmyers a5870fb
Also handle file case for resourceType
qqmyers 24db2af
missed changes
qqmyers f0fd61a
simplify - util checks for null and empty
qqmyers ead153f
typo in DOI parsing logic
qqmyers ea75216
only files in latestversionforcopy
qqmyers 33f8f30
Merge remote-tracking branch 'IQSS/develop' into datacite_xml_improve…
qqmyers b6bd530
fix date parsing, clear bad values
qqmyers e1383d7
relationType entry in citation block
qqmyers 93faade
missing element for openaireutil test
qqmyers c9084e3
contributor type null fix
qqmyers cdd6d6f
add relationType to base code and DataCite XML
qqmyers 360d3fa
add relationType to above fold display
qqmyers 53ded9e
typos
qqmyers 6aade3a
handle blank id no and styling in above fold summary
qqmyers 347971f
skip blanks in geo place name entries
qqmyers bc5686b
use ; to separate kindOfData / resourceTypes
qqmyers db934bb
add Time Period as Other Date
qqmyers 9efe597
support available and updated dates for dataset and file
qqmyers de37314
fix file updated logic
qqmyers 0bbce02
Merge branch 'datacite_xml_improvements' into datacite_plus_relPubRel…
qqmyers 6357d92
fix no relType styling
qqmyers c624c0c
handle null
qqmyers 0c2cff1
add HasPart rels - logic issue
qqmyers a177a08
catch additional exception type
qqmyers 9643b07
Merge branch 'datacite_xml_improvements' into
qqmyers fed231f
fix rendering with a span
qqmyers 08843d8
missing imports, null check
qqmyers c4df868
Merge remote-tracking branch 'IQSS/develop' into datacite_xml_improve…
qqmyers 394adcd
Merge branch 'datacite_xml_improvements' into
qqmyers 1cceab1
Merge remote-tracking branch 'IQSS/develop' into datacite_xml_improve…
qqmyers 33d123f
Merge branch 'datacite_xml_improvements' into datacite_plus_relPubRel…
qqmyers 6c87b9e
fix ROR identification
qqmyers 182cfdd
passthrough for ext cvv/ROR affiliation update
qqmyers f53dacf
Merge branch 'datacite_xml_improvements' into datacite_plus_relPubRel…
qqmyers e2b88ca
Merge branch 'datacite_xml_improvements' into
qqmyers 2124ce6
add relation type values
qqmyers 6e1919a
fix case
qqmyers 567b111
Merge remote-tracking branch 'IQSS/develop' into
qqmyers d19e7f2
missing empty watermark entry
qqmyers 5c041e4
fix capitalization
qqmyers f5326c9
Merge remote-tracking branch 'IQSS/develop' into
qqmyers ea373af
Merge remote-tracking branch 'IQSS/develop' into
qqmyers 7e1f73b
Merge branch 'datacite_xml_improvements' into
qqmyers b432778
fix test
qqmyers 4e298a3
update tests - added one field in citation block
qqmyers 3d6cd3a
release note
qqmyers 4f539ba
support no pubIdType for URLs
qqmyers 25d63a7
direct people to the log for failures - they aren't in the response
qqmyers 92bf051
bug - the _target url isn't being set elsewhere
qqmyers f4c5164
avoid failing when the entity is null for error statuses
qqmyers 45156be
don't update unpublished files - no need and it will fail
qqmyers 5998e7a
lower logging, add null check on relatedIdentifier
qqmyers 3ef9557
Change to use POST for all
qqmyers 4e7d22d
Documentation and updated release note
qqmyers 165bb9d
Merge remote-tracking branch 'IQSS/develop' into datacite_plus_relPub…
qqmyers 1865a81
test fix - number of fields
qqmyers bb7adee
update release note
qqmyers bde5147
check for ROR in grantAgency field too
qqmyers 280ed49
adopt using CDI, fix funderIdentifier element per schema
qqmyers f255f19
release note/changelog changes
qqmyers 194dae8
don't send contributors w/o contributorType
qqmyers 35ff432
relatedIdentifierType is required
qqmyers 6c8f73e
flip to prefer identifier over url
qqmyers 86aec68
Handle case where type is set but there's no identifier
qqmyers 203add1
map non-standard contributors to Other, remove unused imports
qqmyers b06e620
Treat missing contrib type as Other
qqmyers 41c9b29
avoid spurious log warning for others e.g. isbn
qqmyers 6a05bef
changes per review
qqmyers 24a1bdf
Merge remote-tracking branch 'IQSS/develop' into datacite_plus_relPub…
qqmyers 174fcf9
Apply suggestions from code review
qqmyers 088b735
Merge branch 'datacite_plus_relPubRelType' of https://github.com/Qual…
qqmyers 4ae0599
cleaner formatting
qqmyers 8141a78
minor doc tweak #10632
pdurbin c6dd220
No longer needed with use of CDI.current() in XMLMetadataTemplate
qqmyers b1e5020
no longer used and CrossRef ended up using it's own.
qqmyers 0c80b2c
Merge branch 'datacite_plus_relPubRelType' of https://github.com/Qual…
qqmyers 87bd308
add more info about the scope of changes.
qqmyers d265e50
set dataset type before registering pid (which needs the type)
qqmyers c5f12b7
Merge remote-tracking branch 'IQSS/develop' into datacite_plus_relPub…
qqmyers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real meat of what's changing is squirreled away in a Google doc. This doesn't quite sit right with me. 🤔 This is the stuff users might like to know. And the stuff QA will test against.
However, our release notes tend to get long and I'm not sure the details should be here either.
The more I think about it... I'd prefer to have the Google doc copied and pasted here into the release notes. Git is a much better way to preserve this information. And it keeps the info with the pull request.
I'm open to other ideas, of course. Perhaps a new changelog in the guides? Or throw it in the API changelog? A separate text file linked from the release notes and/or the guides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to focus on the 40+ changes, many of which are only relevant if you're comparing old, new, and OpenAIRE closely (and are really closer to per-commit changes we usually make). I've added some additional detail to the release note to try and give more of a sense of the scope of the change (v4.5 schema, files, license/terms info, PIDs, ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this information should be in git but I give up.
Thanks for the additional information in the release note. It does help.