Add mimetype for 3D Data readable by the Smithsonian's Voyager app #10760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added
the
Consider For Next Release
pdurbin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This adds support for *.glb model/gltf-binary 3D models to the mime detection and adds label/facet entries for 3D model / 3D Data
Which issue(s) this PR closes: Needed to support gdcc/dataverse-previewers#57
Closes #
Special notes for your reviewer: See gdcc/dataverse-previewers#57
I've also added / to the @produces annotation on the file download API call. I'm not sure why it is application/xml right now (perhaps only / is needed), but just having application/xml caused a 406 error (with type application/json :-) )when the Voyager app sent an erroneous Accept:"text/plain" header (it also failed with 406 if I made their code ask for model/gltf-binary). When the file is actually returned, it has type model/gltf-binary as it should with this PR, but without listing that explicitly or having /, we return 406 before getting to our code due to the annotation.
Suggestions on how to test this: Minimally, upload a file with a glb extension and verify it gets the mimetype and label above and shows up in a 3D Data facet. To test the overall previewer that handles this mimetype, install a local copy of the new Voyager previewer in gdcc/dataverse-previewers#77, register the new previewer using the curl command, try uploading data such as https://dataverse.harvard.edu/file.xhtml?fileId=6931827&version=1.0 (note you have to upload this file after you deploy the branch or you'll have to redetect the mimetype via API (or change in the DB)). It should show a dynamic 3D view like:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Maybe? There are a few 'beta' 3D previewers that haven't been added to the guides or release notes. Not sure if we want to do that now or when there's a v1.5 release (could be around the 6.4 release if we agree these are no longer beta).
Additional documentation: