-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issues in exporters and citations for PermaLink/non-DOI PIDs #10790
Merged
ofahimIQSS
merged 20 commits into
IQSS:develop
from
vera:fix/perma-exporters-and-citations
Feb 6, 2025
+529
−45
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2b2da99
fix: remove unnecessary slash in perma PIDs in DDI exporters
vera c8cdb8b
fix: remove doi property for perma PIDs in BibTeX citation
vera ccf74f9
fix: fix PID formatting in EndNote XML citation
vera 34a795c
fix: use correct PID separator in DDI exporters (WIP)
vera 825d503
fix: use correct PID separator in DDI exporters (WIP)
vera b8a068e
fix: use correct PID separator in DDI exporters
vera 70031f3
fix: use GlobalId methods to create PID URLs/strings in DdiExportUtil
vera f6e1b06
fix: set separator when creating new dataset
vera 46de8fb
test: add tests for DDI exports for datasets with PermaLinks
vera 3275eba
Merge branch 'develop' into fix/perma-exporters-and-citations
vera 07e327c
fix: fix failing DdiExportUtilTest by updating PermaLink config
vera a553458
fix: improve PID formatting in EndNote XML citation output
vera ae058d1
release note
qqmyers 7317ac9
Merge branch 'develop' into fix/perma-exporters-and-citations
vera cf3ced8
Merge branch 'develop' into fix/perma-exporters-and-citations #10790
pdurbin 0d75b88
rename sql script #10790
pdurbin 746b2b4
new test and doc update
qqmyers 43dcb00
Merge pull request #2 from GlobalDataverseCommunityConsortium/fix/per…
vera ed03452
Merge branch 'develop' into fix/perma-exporters-and-citations
vera b078516
Merge branch 'develop' into fix/perma-exporters-and-citations
vera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
fix: use correct PID separator in DDI exporters (WIP)
commit 34a795c97db8bcfce246bff51231946745981a05
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE dvobject ADD COLUMN IF NOT EXISTS separator character varying(255); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same - can you parse the authority/separator/identifier and use GlobalId.asString() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!