-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement and internationalization of harvest status #11017
base: develop
Are you sure you want to change the base?
Improvement and internationalization of harvest status #11017
Conversation
@jggautier please feel free to check the changes 😃 |
Hi @DS-INRAE. Sorry I just saw your message from last week. I noticed it when this PR was discussed in the Dataverse core team's standup today. I haven't checked out the changes but agreed that when this PR was moved into the review column on the sprint board that I would check out the changes. |
Hi @DS-INRAE and @stevenferey. I just noticed that this PR was in the Ready for Review column, though I'm not sure how long it's been there. Hopefully not too long. I can't see the changes in action, but from the release notes the changes seem to be what you mentioned in the GitHub issue at #9294. @pdurbin did you mean to label this PR as a bug? I'm just wondering if this means that I don't realize something that's been changed or that we're just thinking that what's being changed were bugs and not what was intended. |
@jggautier I just meant that it's a bug that hard-coded English appears. This PR fixes that. Thanks, @stevenferey! ❤️ |
@stevenferey There are 2 tests failing in HarvestingClientsIT. Please fix these so I can continue to review this PR. |
…ation-of-harvest-status
…ation-of-harvest-status
Thanks @stevenwinship , I have made the necessary changes. |
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: