Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement and internationalization of harvest status #11017

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

stevenferey
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@DS-INRAE
Copy link
Member

@jggautier please feel free to check the changes 😃

@coveralls
Copy link

coveralls commented Nov 13, 2024

Coverage Status

coverage: 22.568% (-0.003%) from 22.571%
when pulling 0c7aeb4 on Recherche-Data-Gouv:9294-improvement-and-internationalization-of-harvest-status
into a4d0127 on IQSS:develop.

@pdurbin pdurbin added Type: Bug a defect Size: 3 A percentage of a sprint. 2.1 hours. labels Nov 13, 2024
@jggautier
Copy link
Contributor

Hi @DS-INRAE. Sorry I just saw your message from last week. I noticed it when this PR was discussed in the Dataverse core team's standup today. I haven't checked out the changes but agreed that when this PR was moved into the review column on the sprint board that I would check out the changes.

@cmbz cmbz added FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) labels Nov 21, 2024
@jggautier
Copy link
Contributor

jggautier commented Dec 2, 2024

Hi @DS-INRAE and @stevenferey. I just noticed that this PR was in the Ready for Review column, though I'm not sure how long it's been there. Hopefully not too long.

I can't see the changes in action, but from the release notes the changes seem to be what you mentioned in the GitHub issue at #9294.

@pdurbin did you mean to label this PR as a bug? I'm just wondering if this means that I don't realize something that's been changed or that we're just thinking that what's being changed were bugs and not what was intended.

@pdurbin
Copy link
Member

pdurbin commented Dec 3, 2024

@jggautier I just meant that it's a bug that hard-coded English appears. This PR fixes that. Thanks, @stevenferey! ❤️

@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 5, 2024
@stevenwinship stevenwinship self-assigned this Dec 9, 2024
@stevenwinship
Copy link
Contributor

@stevenferey There are 2 tests failing in HarvestingClientsIT. Please fix these so I can continue to review this PR.
Thanks

@stevenferey
Copy link
Contributor Author

Thanks @stevenwinship , I have made the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
Status: Ready for QA ⏩
Status: 🚧 Dev by Recherche Data Gouv
8 participants