-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate DatasetFieldTypes #11066
base: develop
Are you sure you want to change the base?
remove duplicate DatasetFieldTypes #11066
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm a little worried about the hard-coded dataset field type counts in the integration tests, but I guess that's the way it already was.
There seems to be some conflicts with the PR. Could you please resolve? Thanks! |
What this PR does / why we need it: Prevent duplicate DatasetFieldTypes from being returned via getMetadataBlock api endpoint
Which issue(s) this PR closes: #10472
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?:
Additional documentation: