Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate DatasetFieldTypes #11066

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: Prevent duplicate DatasetFieldTypes from being returned via getMetadataBlock api endpoint

Which issue(s) this PR closes: #10472

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship marked this pull request as draft December 5, 2024 20:41
@stevenwinship stevenwinship self-assigned this Dec 5, 2024
@stevenwinship stevenwinship added Feature: Metadata Feature: API Size: 10 A percentage of a sprint. 7 hours. FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Type: Bug a defect labels Dec 5, 2024

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Dec 6, 2024

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10472-review-modify-jsonprinter-for-datasetfieldtype
ghcr.io/gdcc/configbaker:10472-review-modify-jsonprinter-for-datasetfieldtype

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller self-assigned this Dec 16, 2024
@stevenwinship stevenwinship marked this pull request as ready for review December 16, 2024 16:26
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm a little worried about the hard-coded dataset field type counts in the integration tests, but I guess that's the way it already was.

@sekmiller sekmiller removed their assignment Dec 16, 2024
@ofahimIQSS
Copy link
Contributor

There seems to be some conflicts with the PR. Could you please resolve? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: API Feature: Metadata FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Review/modify: jsonPrinter for datasetFieldType
3 participants