Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generation of the related publication idenetifier url #8658

Closed

Conversation

ErykKul
Copy link
Collaborator

@ErykKul ErykKul commented Apr 28, 2022

What this PR does / why we need it:
The indetifiers in the "Related publication" field of the metadata as shown in the dataset overview can have wrong URL. This happens when the URL provided in the metadata points to a related webpage i.s.o. being an identifier URL. When no URL is provided, the identifier has no URL. This pull request solves this by generating an URL from the given identifier and using it i.s.o. the user provided URL that could be anything.

Which issue(s) this PR closes:

Closes #8657

Suggestions on how to test this:
Make a dataset with a related publicaction as described in the issue and verify the URL in the identifier link.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 19.238% when pulling 18df959 on ErykKul:8657_related_publication_identifier_url into fdef1f6 on IQSS:develop.

@ErykKul ErykKul closed this Aug 8, 2022
@ErykKul ErykKul force-pushed the 8657_related_publication_identifier_url branch from 18df959 to d372298 Compare August 8, 2022 08:45
@ErykKul ErykKul deleted the 8657_related_publication_identifier_url branch August 8, 2022 09:21
@mreekie mreekie added bk2211 and removed bk2211 labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Interesting/To keep an eye on
Development

Successfully merging this pull request may close these issues.

Related publication identifier URL does not correspond to the identifier
3 participants