Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/7349-5 - Use brand name for catalog #9101

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 28, 2022

What this PR does / why we need it: Google uses the catalog name to suggest where to 'Explore' a dataset:
image

For repositories that use a brand name different than the root collection name, it would be better to use it so that Google shows a button with the repository brand name.

Which issue(s) this PR closes:

Closes #7349

Special notes for your reviewer: We already used brand name (which defaults to the root collection name) for the provider/publisher entries in schema.org so this just makes the includedInDataCatalog entry work the same way.

Suggestions on how to test this: Set a brand name and verify that the schema.org metadata export uses it for the includedInDataCatalog key.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: the other IQSS/7349-* PRs have release notes - not sure this needs another.

Additional documentation:

@qqmyers qqmyers added the GDCC: QDR of interest to QDR label Oct 28, 2022
@coveralls
Copy link

coveralls commented Nov 7, 2022

Coverage Status

Coverage: 19.999% (-0.001%) from 20.0% when pulling 241b570 on QualitativeDataRepository:IQSS/7349-5_brandname_as_catalog into ecc23c0 on IQSS:develop.

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 14, 2022
@qqmyers
Copy link
Member Author

qqmyers commented Jan 20, 2023

The whole set of #7349-related PRs are fairly straight-forward change to the metadata we embed in the page for Google/others. They should be easy to review/QA.

@scolapasta scolapasta added this to the 5.13 milestone Jan 24, 2023
@scolapasta
Copy link
Contributor

I just approved this (it was trivial while reviewing for milestone 5.13) so this should go straight to Ready for QA).

@mreekie
Copy link

mreekie commented Jan 25, 2023

sprint prep

  • needed for 5.13. moved over

@kcondon kcondon self-assigned this Jan 30, 2023
@kcondon
Copy link
Contributor

kcondon commented Jan 30, 2023

@qqmyers Please refresh from develop: flyway versioning issues, can't deploy.

@kcondon kcondon merged commit 0d1812b into IQSS:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: QDR of interest to QDR Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Improve/update Schema.org JSON-LD export
5 participants