-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQSS/7349-5 - Use brand name for catalog #9101
Merged
kcondon
merged 5 commits into
IQSS:develop
from
QualitativeDataRepository:IQSS/7349-5_brandname_as_catalog
Jan 30, 2023
Merged
IQSS/7349-5 - Use brand name for catalog #9101
kcondon
merged 5 commits into
IQSS:develop
from
QualitativeDataRepository:IQSS/7349-5_brandname_as_catalog
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole set of #7349-related PRs are fairly straight-forward change to the metadata we embed in the page for Google/others. They should be easy to review/QA. |
scolapasta
approved these changes
Jan 24, 2023
I just approved this (it was trivial while reviewing for milestone 5.13) so this should go straight to Ready for QA). |
sprint prep
|
@qqmyers Please refresh from develop: flyway versioning issues, can't deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Google uses the catalog name to suggest where to 'Explore' a dataset:
For repositories that use a brand name different than the root collection name, it would be better to use it so that Google shows a button with the repository brand name.
Which issue(s) this PR closes:
Closes #7349
Special notes for your reviewer: We already used brand name (which defaults to the root collection name) for the provider/publisher entries in schema.org so this just makes the includedInDataCatalog entry work the same way.
Suggestions on how to test this: Set a brand name and verify that the schema.org metadata export uses it for the includedInDataCatalog key.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: the other IQSS/7349-* PRs have release notes - not sure this needs another.
Additional documentation: