-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation; OpenSSL needs Root install #40
base: master
Are you sure you want to change the base?
Conversation
It took me a few runs to figure out why dependancies were failing at least on OSX, following the instructions, It took a bunch of log checking to figure out that openssl was failing, but was not obvious, as it would error on a different package that was an intermediary. OpenSSL couldn't built without root because of the out-of-R tree it required.
hi, thanks for the info. but this apparently hasn’t been true for me, so it’s probably platform specific. maybe you could instead add the information into the |
Changed the OSX OpenSSL instructions to an aside. May possibly need moving out of current block, but I believe it should be active here because of the tabs stanza.
@flying-sheep on linux it wouldn't apply, as it appears not to on windows. Maybe OSX and windows should be separated? The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please also show how it looks after the changes in a screenshot?
@@ -19,10 +19,28 @@ | |||
<a href="#devel-panel" class=mdl-tabs__tab>Development</a> | |||
</div> | |||
<div class="mdl-tabs__panel is-active" id=binary-panel> | |||
<aside class="card-note mdl-card mdl-shadow--2dp"> | |||
<div class="mdl-card__title"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please leave out quotes when there’s only one class
<pre class="r mdl-shadow--2dp"><code>> | ||
user$ sudo R | ||
> install.packages(c('openssl') | ||
> quit()</code></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don’t add quit()
and how to start an R interpreter. people know how to do that 😉
about your concerns for platform-specific instructions: maybe we should just switch to a UI where people select their platform and if the want a non-standard install (e.g. dev versions), and only then show instructions |
hi, why did you close this? it just needed a few changes to be merged |
@flying-sheep oh, I was trying to clean up my laundry list of PR's, and didn't realize it was still of interest. But if it is still relevant, I will re-open, I had a huge project sent out and was trying to id things of interest still to upstream. reopen |
thank you! would you like to do the requested changes or should i just close this and make the edits manually? |
It took me a few runs to figure out why dependancies were failing at least on OSX, following the instructions, It took a bunch of log checking to figure out that openssl was failing, but was not obvious, as it would error on a different package that was an intermediary.
OpenSSL couldn't built without root because of the out-of-R tree it required.