Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation; OpenSSL needs Root install #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update installation; OpenSSL needs Root install #40

wants to merge 2 commits into from

Conversation

BenjaminHCCarr
Copy link

It took me a few runs to figure out why dependancies were failing at least on OSX, following the instructions, It took a bunch of log checking to figure out that openssl was failing, but was not obvious, as it would error on a different package that was an intermediary.

OpenSSL couldn't built without root because of the out-of-R tree it required.

It took me a few runs to figure out why dependancies were failing at least on OSX, following the instructions, It took a bunch of log checking to figure out that openssl was failing, but was not obvious, as it would error on a different package that was an intermediary.

OpenSSL couldn't built without root because of the out-of-R tree it required.
@flying-sheep
Copy link
Member

hi, thanks for the info.

but this apparently hasn’t been true for me, so it’s probably platform specific.

maybe you could instead add the information into the <aside/> here? (because that’s already about an OSX quirk)

Changed the OSX OpenSSL instructions to an aside.
May possibly need moving out of current block, but I believe it should be active here because of the tabs stanza.
@BenjaminHCCarr
Copy link
Author

@flying-sheep on linux it wouldn't apply, as it appears not to on windows. Maybe OSX and windows should be separated?
similar to: https://irkernel.github.io/installation/#source-panel
if the instructions are platform dependent as well

The Source title is a little misleading, as apt-get and yum are installing binary files, not pulling the raw source and compiling most of the code. It's just some aspects of the Jupyter code that are being recompiled.

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also show how it looks after the changes in a screenshot?

@@ -19,10 +19,28 @@
<a href="#devel-panel" class=mdl-tabs__tab>Development</a>
</div>
<div class="mdl-tabs__panel is-active" id=binary-panel>
<aside class="card-note mdl-card mdl-shadow--2dp">
<div class="mdl-card__title">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave out quotes when there’s only one class

<pre class="r mdl-shadow--2dp"><code>>
user$ sudo R
> install.packages(c('openssl')
> quit()</code></pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don’t add quit() and how to start an R interpreter. people know how to do that 😉

@flying-sheep
Copy link
Member

about your concerns for platform-specific instructions:

maybe we should just switch to a UI where people select their platform and if the want a non-standard install (e.g. dev versions), and only then show instructions

@flying-sheep
Copy link
Member

hi, why did you close this? it just needed a few changes to be merged

@BenjaminHCCarr
Copy link
Author

@flying-sheep oh, I was trying to clean up my laundry list of PR's, and didn't realize it was still of interest. But if it is still relevant, I will re-open, I had a huge project sent out and was trying to id things of interest still to upstream.

reopen

@BenjaminHCCarr BenjaminHCCarr reopened this Jun 7, 2017
@flying-sheep
Copy link
Member

thank you! would you like to do the requested changes or should i just close this and make the edits manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants