Fix plots

ISI-MIP · Nov 29, 2023 · 9be1af1 · 9be1af1
1 parent d415836
commit 9be1af1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/isimip_qa/plots/dayofyear.py b/isimip_qa/plots/dayofyear.py
@@ -15,7 +15,8 @@ class DayOfYearPlot(FigurePlotMixin, GridPlotMixin, Plot):
     def get_df(self, dataset):
         extraction = self.extraction_class(dataset, self.region, self.period)
         df = extraction.read()
-        return (df.groupby(lambda x: x.dayofyear).mean() - df.mean()) / df.std()
+        mean, std =  df.mean().values, df.std().values
+        return (df.groupby(lambda x: x.dayofyear).mean() - mean) / (std if std > 0 else 1.0)
 
     def get_attrs(self, dataset):
         return AttrsExtraction(dataset, self.region, self.period).read()

diff --git a/isimip_qa/plots/monthofyear.py b/isimip_qa/plots/monthofyear.py
@@ -15,7 +15,8 @@ class MonthOfYearPlot(FigurePlotMixin, GridPlotMixin, Plot):
     def get_df(self, dataset):
         extraction = self.extraction_class(dataset, self.region, self.period)
         df = extraction.read()
-        return (df.groupby(lambda x: x.month).mean() - df.mean()) / df.std()
+        mean, std =  df.mean().values, df.std().values
+        return (df.groupby(lambda x: x.month).mean() - mean) / (std if std > 0 else 1.0)
 
     def get_attrs(self, dataset):
         return AttrsExtraction(dataset, self.region, self.period).read()

diff --git a/isimip_qa/tests/test_plots.py b/isimip_qa/tests/test_plots.py
@@ -53,4 +53,4 @@ def test_plot(settings, dataset_path, extraction_class, plot_class):
 
             similarity = ssim(img, template_img, data_range=template_img.max() - template_img.min())
 
-            assert similarity == 1.0
+            assert similarity > 0.999999